Looks good. One minor technical point: the action should mention
gmtime/gmtime_r whenever it mentions localtime/localtime_r. To be
specific:
> Date: Wed, 16 Jan 2002 02:02:27 GMT
> From: yyyyyy@xxxxxxxxxxxxxxx
> If a 'struct tm' broken-down time structure is created by
Insert "gmtime(), gmtime_r()," here.
> localtime() or localtime_r(), or modified by mktime(), and the value
> of TZ is subsequently modified, the results of the %Z and %z
> strftime() conversion specifiers is undefined, when strftime() is
> called with such a broken-down time structure.
>
> If the broken-down time structure is subsequently modified by a
> successful call to mktime() or
Insert "gmtime_r() or" here.
> localtime_r(), the results of these
> conversion specifiers are once again defined.
And "once again defined" might need rephrasing since gmtime_r() might
use UTC and might use local time for the specifiers.
|