Email List: Xaustin-review-lX
[All Lists]

Re: Defect in XCU patch

To: yyyyyyyyyyyyyyy@xxxxxxxxxxxxx
Subject: Re: Defect in XCU patch
From: Paul Eggert <yyyyyy@xxxxxxxxxxx>
Date: Fri, 7 Jun 2002 13:37:20 -0700 (PDT)
References: <200206071510.g57FAkEj015837@xxxxxx> <0dfe01c20e51$6e4b1770$49036a83@xxxxxx>
> From: "Nick Stoughton" <yyyy@xxxxxxxxxx>
> Date: Fri, 7 Jun 2002 11:30:42 -0700
> 
> Well, the implementations I have checked (Solaris, FreeBSD, and Linux) all
> work so that compiling the modified source WITHOUT -D DEFNAME is equivalent
> to compiling the original. That is, the additions (and subtractions) are
> marked by #ifdef DEFNAME (or #ifndef DEFNAME).
> 
> This also seems to me to be the intuitive answer. I would vote in favor of
> requiring this unless someone can show substantial existing practice the
> other way.

I should mention that some test versions of GNU patch have behaved the
wrong way, due to a bug.  Perhaps these are the implementations that
Geoff Clare was thinking of?  If so, please disregard them: that
behavior was clearly a bug, and it has been fixed in the latest test
version.

<Prev in Thread] Current Thread [Next in Thread>