Email List: Xaustin-review-lX
[All Lists]

Defect in XSH pthread_create()

To: yyyyyyyyyyyyyyy@xxxxxxxxxxxxx
Subject: Defect in XSH pthread_create()
From: yyyyyyy@xxxxxxxxxx
Date: Tue, 11 Feb 2003 01:30:57 GMT
        Defect report from : Ulrich Drepper , Red Hat

(Please direct followup comments direct to yyyyyyyyyyyyyy@xxxxxxxxxxxxx)

@ page 1046 line 32866 section pthread_create() objection {ud-ptcreate}

Problem:

Defect code :  1. Error

The error section of pthread_create() currently states:

[EINVAL] The value specified by attr is invalid.


That's a very vague description.

I could not agree to the requirement that pthread_create() has to be able to 
detect stray pointers passed for this parameter.  Just like in the rest of the 
specification, it is the programmers responsibility to pass NULL or a valid 
pointer to a pthread_attr_t object.

What I instead think the error can require is that if a pthread_attr_t object 
with invalid content is passed to pthread_create() an error is returned.  Note: 
'value' is very vague.  What value?  But then again: maybe the pthread_attr_t 
object contains a pointer which, if corrupted somehow, can take on any value.


For this reasons I think this error should be made optional.

Action:

Remove line 32866 and add after line 32868:

The pthread_create() function may fail if:

[EINVAL] The attributes specified by attr are invalid.

<Prev in Thread] Current Thread [Next in Thread>
  • Defect in XSH pthread_create(), drepper <=